Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation strategy in changes summary is missing for fallback-on-update-or-noop #622

Closed
praveenrewar opened this issue Oct 17, 2022 · 0 comments · Fixed by #628
Closed
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor snack This issue has been identified as lightweight and potentially quick to deliver.

Comments

@praveenrewar
Copy link
Member

What steps did you take:
Tried deploying a resource with the fallback-on-update-or-noop create-strategy.

$ cat config.yml
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: cm-1
  annotations:
    kapp.k14s.io/create-strategy: "fallback-on-update-or-noop"
data:
  key: value
  
$ kapp deploy -a test -f config.yml
Target cluster 'https://192.168.64.6:8443' (nodes: minikube)

Changes

Namespace  Name  Kind       Age  Op      Op st.  Wait to    Rs  Ri
default    cm-1  ConfigMap  -    create  ???     reconcile  -   -

What happened:
The operation strategy in the changes summary table was shown as ???.

What did you expect:
Correct operation strategy to be shown in the table.

Anything else you would like to add:
We just need to add value for createStrategyFallbackOnUpdateOrNoopAnnValue after this.

Environment:

  • kapp version (use kapp --version):
  • OS (e.g. from /etc/os-release):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@praveenrewar praveenrewar added bug This issue describes a defect or unexpected behavior good first issue An issue that will be a good candidate for a new contributor carvel accepted This issue should be considered for future work and that the triage process has been completed snack This issue has been identified as lightweight and potentially quick to deliver. labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor snack This issue has been identified as lightweight and potentially quick to deliver.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant