Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback-on-update-or-noop create-strategy to changes summary #628

Merged
merged 1 commit into from
Oct 24, 2022
Merged

add fallback-on-update-or-noop create-strategy to changes summary #628

merged 1 commit into from
Oct 24, 2022

Conversation

PiotrLewandowski323
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #622

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: PiotrLewandowski323 <lewandowski323@gmail.com>
@vmwclabot
Copy link

@PiotrLewandowski323, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@PiotrLewandowski323, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @PiotrLewandowski323 🚀
Changes look good to me. I will wait for the checks to go green and cla bot to give a go ahead before merging the PR.

@vmwclabot
Copy link

@PiotrLewandowski323, VMware has approved your signed contributor license agreement.

@praveenrewar praveenrewar merged commit c056b6b into carvel-dev:develop Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation strategy in changes summary is missing for fallback-on-update-or-noop
3 participants