Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update --preflight flag to no longer follow the Check=true format #893

Closed
everettraven opened this issue Mar 4, 2024 · 3 comments · Fixed by #894
Closed

Update --preflight flag to no longer follow the Check=true format #893

everettraven opened this issue Mar 4, 2024 · 3 comments · Fixed by #894
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@everettraven
Copy link
Contributor

In some discussions around carvel-dev/carvel#729 it's come to my attention that with all preflight checks being disable by default, it doesn't make much sense to require the enabling of preflight checks to follow the format of --preflight=Check=true,OtherCheck=true,... and could instead follow the format of --preflight=Check,OtherCheck,.... This makes it follow an "enabler" pattern where all preflight checks must be explicitly enabled
@everettraven everettraven added the carvel triage This issue has not yet been reviewed for validity label Mar 4, 2024
@everettraven
Copy link
Contributor Author

@tmshort expressed interest in working on this.

@everettraven
Copy link
Contributor Author

@100mik @praveenrewar What are your thoughts on this?

@praveenrewar
Copy link
Member

@everettraven Sounds good to me! Thanks you so much for all that you are doing 🙇🏻

@praveenrewar praveenrewar added the carvel accepted This issue should be considered for future work and that the triage process has been completed label Mar 4, 2024
tmshort added a commit to tmshort/kapp that referenced this issue Mar 4, 2024
@tmshort
Update --preflight command line option
b100284 
Fix carvel-dev#893

The `--preflight` command line options now only specifies those preflight
checks that are to be enables.

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort mentioned this issue Mar 4, 2024
Merged
5 tasks
tmshort added a commit to tmshort/kapp that referenced this issue Mar 4, 2024
@tmshort
Update --preflight command line option
c38a47a 
Fix carvel-dev#893

The `--preflight` command line options now only specifies those preflight
checks that are to be enables.

Signed-off-by: Todd Short <todd.short@me.com>
@renuy renuy added enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed carvel triage This issue has not yet been reviewed for validity labels Mar 5, 2024
praveenrewar pushed a commit that referenced this issue Mar 7, 2024
@tmshort
Update --preflight command line option (#894)
ff35d20 
Fix #893

The `--preflight` command line options now only specifies those preflight
checks that are to be enables.

Signed-off-by: Todd Short <todd.short@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update --preflight command line option tmshort/kapp
3 participants
@renuy @praveenrewar @everettraven