Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAPP-1000: Apply noop changes after everything else #1001

Closed
wants to merge 4 commits into from

Conversation

OlofKalufs
Copy link

What this PR does / why we need it:

This is a workaround for the problem when a noop apply fails due to dependencies that is later in the dependency stage (even though the noop is declared to be dependent on them)

Which issue(s) this PR fixes:

Fixes #1000

Does this PR introduce a user-facing change?

I'm not sure of the implications of this,

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar
Copy link
Member

Closing this as the issue is closed, and we might need to iron out the solution before we make a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Noop changes should observe change rules for upserting, or be performed last
2 participants