Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new flag 'new-namespace' for renaming apps(#165) #294

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Conversation

renuy
Copy link
Contributor

@renuy renuy commented Aug 26, 2021

No description provided.

@renuy renuy linked an issue Aug 26, 2021 that may be closed by this pull request
@renuy renuy requested a review from 100mik August 26, 2021 13:08
@100mik 100mik marked this pull request as ready for review August 26, 2021 13:11
pkg/kapp/cmd/app/rename.go Show resolved Hide resolved
pkg/kapp/cmd/app/rename.go Outdated Show resolved Hide resolved
pkg/kapp/cmd/app/rename.go Outdated Show resolved Hide resolved
@renuy
Copy link
Contributor Author

renuy commented Aug 30, 2021

@cppforlife ,
2 more queries

  1. If we rename the app, should the app history also reflect that. (there is todo in recorded_app.go (line 209)
  2. should history be also moved to new namespace?

@cppforlife
Copy link
Contributor

per our discussion, we ll leave app changes where they are.

@cppforlife cppforlife merged commit f1da00e into develop Aug 30, 2021
@praveenrewar praveenrewar deleted the 165 branch March 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kapp rename should support optional --new-namespace
3 participants