Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving how warnings are displayed #299

Merged
merged 12 commits into from
Sep 9, 2021
Merged

Improving how warnings are displayed #299

merged 12 commits into from
Sep 9, 2021

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Aug 31, 2021

Changes:

  • deps_factory.go now has a function which returns a DynamicClient which does not produce warnings. Called MutedDynamicClient.
  • The ResourcesImpl now has a MutedDynamicClient , NewResourcesImpl() and all references updated accordingly.
  • All() in resources.go uses a MutedDynamicClient to make API calls.

@100mik 100mik linked an issue Aug 31, 2021 that may be closed by this pull request
All K8s warning displayed while running any command #287
Closed
100mik
100mik commented Sep 2, 2021
View reviewed changes
pkg/kapp/cmd/app/inspect.go Outdated Show resolved Hide resolved
@100mik 100mik marked this pull request as ready for review September 2, 2021 10:35
100mik
100mik commented Sep 7, 2021
View reviewed changes
test/e2e/warnings_test.go Outdated Show resolved Hide resolved
@cppforlife cppforlife merged commit 64719b6 into carvel-dev:develop Sep 9, 2021
@100mik 100mik mentioned this pull request Feb 3, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar left review comments

@rohitagg2020 rohitagg2020 Awaiting requested review from rohitagg2020

@sethiyash sethiyash Awaiting requested review from sethiyash

@renuy renuy Awaiting requested review from renuy

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All K8s warning displayed while running any command
5 participants
@100mik @cppforlife @praveenrewar @rohitagg2020 @vmwclabot