-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'versioned-explicit-ref' annotation #311
Add 'versioned-explicit-ref' annotation #311
Conversation
questions to be resolved:
|
We have to consider a resource that might wanna have multiple versioned resources referenced explicitly. |
870d46a
to
09853d1
Compare
Changed how explicit references are structured. Multiple references are now supported using the format specified here. The format should also address our other requirements. |
09853d1
to
cb27d10
Compare
Will attempt appending existing annotation instead of adding labels. Do we also wanna avoid adding more annotations? |
yup, as much as possible. (especially ones that we would have to add automatically) |
cb27d10
to
0475c8a
Compare
For example: {
"references":[
{
"namespace":"default",
"kind":"ConfigMap",
"name":"config-1"
},
{
"namespace":"default",
"kind":"ConfigMap",
"name":"config-2"
}
]
} The updated value is: {
"references":[
{
"namespace":"default",
"apiGroup":"",
"kind":"ConfigMap",
"name":"config-1"
},
{
"namespace":"default",
"apiGroup":"",
"kind":"ConfigMap",
"name":"config-2"
}
],
"VersionedNames":{
"default//ConfigMap/config-1":"config-1-ver-2",
"default//ConfigMap/config-2":"config-2-ver-3"
}
} The versioned names are the updated ones added by kapp. Demo YAML on gist. |
0475c8a
to
69d2f7f
Compare
8d4ace3
to
15512b2
Compare
lets refine this a bit more... let's support secretRef:
name:
kind:
... another question to think about is, should we use json or yaml within that annotation? e.g.
|
1e751a4
to
0d1020b
Compare
0d1020b
to
ae0480f
Compare
ae0480f
to
22cdaad
Compare
22cdaad
to
9fb799a
Compare
c0d4758
to
a692a0e
Compare
a692a0e
to
ec62788
Compare
ec62788
to
8931239
Compare
8931239
to
94e364e
Compare
Synthetic reference to a versioned resource.
For example:
The value of the key
name
is to be replaced by the latest versioned name of the referred resourcePending: