Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use testify/require instead of value comparisons and Fatal #347

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Update tests to use testify/require instead of value comparisons and Fatal #347

merged 1 commit into from
Oct 8, 2021

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Oct 7, 2021 •
edited
Loading

Update all tests to use testify/require instead value comparisons and Fatal() as it's more clean and provides error message in a more intuitive way.

@praveenrewar praveenrewar changed the title Update old tests to use testify/require instead of value comparisons and Fatal Update tests to use testify/require instead of value comparisons and Fatal Oct 7, 2021
@praveenrewar praveenrewar reopened this Oct 7, 2021
@praveenrewar praveenrewar requested a review from a team October 7, 2021 13:10
@praveenrewar praveenrewar marked this pull request as ready for review October 8, 2021 05:22
@praveenrewar praveenrewar mentioned this pull request Oct 8, 2021
Closed
4 tasks
@praveenrewar praveenrewar self-assigned this Oct 8, 2021
@rohitagg2020 rohitagg2020 merged commit db1549f into develop Oct 8, 2021
@praveenrewar praveenrewar deleted the old-tests-update branch June 8, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100mik 100mik 100mik approved these changes

Assignees

@praveenrewar praveenrewar

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praveenrewar @100mik @vmwclabot @rohitagg2020