Update resources tests to use testify/require #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenrewar
added
the
hacktoberfest-accepted
Update all tests in `pkg/kapp/resources` to use `testify/require` instead value comparisons and `Fatal()` as it's more clean and provides error message in a more intuitive way Issue carvel-dev#349
khan-ajamal
force-pushed
the
refactor-tests
branch
from
1ec6ffc
to
0de44f8
Compare
praveenrewar
approved these changes
Oct 19, 2021
praveenrewar
pushed a commit
that referenced
this pull request
Oct 26, 2021
Update all tests in `pkg/kapp/resources` to use `testify/require` instead value comparisons and `Fatal()` as it's more clean and provides error message in a more intuitive way Issue #349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all tests in
pkg/kapp/resourcesto usetestify/requireinstead of value comparisons andFatal()as it's cleaner and provides error messages in a more intuitive wayIssue #349