Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use testify/require #356

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

ShajithaMohammed
Copy link
Contributor

Update tests in pkg/kapp/resourcemisc to use testify/require instead of value comparisons and Fatal.
Fixes #349

@vmwclabot
Copy link

@ShajithaMohammed, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot.

@100mik 100mik added the hacktoberfest-accepted Marks PRs accepted as a contribution to Hacktoberfest label Oct 16, 2021
@cppforlife cppforlife merged commit 67ce19c into carvel-dev:develop Oct 22, 2021
@vmwclabot
Copy link

@ShajithaMohammed, VMware has approved your signed contributor license agreement.

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Oct 25, 2021
praveenrewar pushed a commit that referenced this pull request Oct 26, 2021
* 349 | Update tests to use testify/require

* Format import statements
@aaronshurley aaronshurley removed the carvel triage This issue has not yet been reviewed for validity label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Marks PRs accepted as a contribution to Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to use testify/require instead of value comparisons and Fatal
6 participants