Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

349 | Update tests to use testify/require #358

Merged
merged 4 commits into from
Oct 26, 2021
Merged

349 | Update tests to use testify/require #358

merged 4 commits into from
Oct 26, 2021

Conversation

ShajithaMohammed
Copy link
Contributor

Update tests in test/e2e to use testify/require instead of value comparisons and Fatal.
Fixes #349

@100mik
Copy link
Contributor

100mik commented Oct 20, 2021

Could you please run ./hack/build.sh and commit changes after that once?
I would definitely recommend setting up the local dev environment and running ./hack/test-all.sh once before committing changes!

praveenrewar
praveenrewar reviewed Oct 21, 2021
View reviewed changes
test/e2e/annotations_test.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/diff_test.go Show resolved Hide resolved
test/e2e/version_test.go Outdated Show resolved Hide resolved
test/e2e/wait_timeout_test.go Outdated Show resolved Hide resolved
test/e2e/warnings_test.go Outdated Show resolved Hide resolved
test/e2e/warnings_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_resource.go Outdated Show resolved Hide resolved
@praveenrewar praveenrewar added the hacktoberfest-accepted Marks PRs accepted as a contribution to Hacktoberfest label Oct 21, 2021
@ShajithaMohammed ShajithaMohammed force-pushed the 349-Refactor-e2e-tests branch 2 times, most recently from 49650b8 to 2ea72e1 Compare October 23, 2021 11:08
praveenrewar
praveenrewar reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the minor indentation issues, it looks good.

test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/warnings_test.go Show resolved Hide resolved
test/e2e/env.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
test/e2e/config_test.go Outdated Show resolved Hide resolved
praveenrewar
praveenrewar reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will merge it after taking a final look in the morning.

@vmwclabot
Copy link

@ShajithaMohammed, VMware has approved your signed contributor license agreement.

@praveenrewar praveenrewar merged commit fc4e6d7 into carvel-dev:develop Oct 26, 2021
praveenrewar pushed a commit that referenced this pull request Oct 26, 2021
@ShajithaMohammed @praveenrewar
Update tests to use testify/require (#358)
c2fecee 
Update tests to use testify/require in test/e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100mik 100mik 100mik approved these changes

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Marks PRs accepted as a contribution to Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tests to use testify/require instead of value comparisons and Fatal
4 participants
@ShajithaMohammed @100mik @vmwclabot @praveenrewar