Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exists annotation test to be more real world oriented #400

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Dec 22, 2021

The current example used for testing exists annotation consists of a Namespace and a ConfigMap where the ConfigMap is an external resource with the exists annotation. In the app there is no resource that depends on the ConfigMap, hence the example doesn't depict the correct use case for the exists annotation.

The example is technically correct but I felt like it can be improved a little bit. So instead of the ConfigMap, I used the Namespace as an external resource, and since the ConfigMap is supposed to be created inside that Namespace, it actually needs it to exists.

@praveenrewar praveenrewar marked this pull request as ready for review December 22, 2021 14:22
@cppforlife cppforlife merged commit a87ea8d into develop Dec 26, 2021
@praveenrewar praveenrewar deleted the exists-ann branch June 8, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants