Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix help for -a to correctly include label:name=key #51

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented Nov 15, 2019

Current help for logs command -a option is missing label in format. So changing:

➜  kapp git:(logs-a-label) ./kapp logs -h
Print app's Pod logs

Usage:
  kapp logs [flags]

Aliases:
  logs, l

Flags:
  -a, --app string         Set app name (or label selector) (format: name, key=val, !key)
...

to

➜  kapp git:(logs-a-label) ./kapp logs -h
Print app's Pod logs

Usage:
  kapp logs [flags]

Aliases:
  logs, l

Flags:
  -a, --app string         Set app name (or label selector) (format: name, label:key=val, !key)
...

which is the correct way of specifying a label selector.

@cppforlife cppforlife merged commit a4f7e80 into carvel-dev:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants