Ignore rules for aggregate ClusterRoles #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregate ClusterRole have their rules filled in by the control plane at runtime. There is no need for kapp to manage this field as it will only create churn that the control plane has to then undo. By adding a default rebase rule for ClusterRoles that have an aggregationRule field set, we can ignore the rules on update. Refs https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles Signed-off-by: Scott Andrews <andrewssc@vmware.com>
praveenrewar
approved these changes
Jun 8, 2022
Comment on lines
+189
to
+190
| emptyFieldMatcher: | ||
| path: [aggregationRule] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Aggregate ClusterRole have their rules filled in by the control plane at
runtime. There is no need for kapp to manage this field as it will only
create churn that the control plane has to then undo.
By adding a default rebase rule for ClusterRoles that have an
aggregationRule field set, we can ignore the rules on update.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Refs https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: