Set default e2e namespace and create it if needed #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Martínez Bevià <vicmarbev@gmail.com>
…mands in the pipe fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Víctor Martínez Bevià vicmarbev@gmail.com
What this PR does / why we need it:
Sets a default value for KAPP_E2E_NAMESPACE if the variable is not set. Creates the namespace if it doesn't exist.
Which issue(s) this PR fixes:
Fixes #538
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Followed the solution at: carvel-dev/kapp-controller#752
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: