Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #540

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Fix flaky tests #540

merged 2 commits into from
Jun 27, 2022

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Jun 23, 2022

What this PR does / why we need it:

  • Make TestSupportUnblockingChanges more deterministic
  • Update TestYttRebaseRule... to make it work with kubernetes v1.24.0+ along with previous versions.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar praveenrewar marked this pull request as draft June 23, 2022 13:40
@praveenrewar praveenrewar changed the title Fix flakey tests Fix flaky tests Jun 23, 2022
@praveenrewar praveenrewar marked this pull request as ready for review June 23, 2022 17:41
test/e2e/config_test.go Outdated Show resolved Hide resolved
Starting with Kubernetes v1.24.0, the service account controller no longer adds a service token secret to a service account
@cppforlife cppforlife merged commit 5a0e06e into develop Jun 27, 2022
@praveenrewar praveenrewar deleted the flakey-tests branch June 27, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants