-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
476: change-rule to delete packageInstall/app before service account and RBAC #552
Conversation
…e deleting svc account and RBAC
With these changes ordering of Upsert: (There is no change in
Delete:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good now.
pkg/kapp/config/default.go
Outdated
resourceMatchers: | ||
- apiVersionKindMatcher: {kind: App, apiVersion: kappctrl.k14s.io/v1alpha1} | ||
|
||
- name: change-groups.kapp.k14s.io/packageinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change-groups.kapp.k14s.io/packageinstall => change-groups.kapp.k14s.io/kapp-controller-packageinstall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
This PR has change-rule added in default.go to delete packageInstall/app (kctrl App CR) before service account and RBAC
Which issue(s) this PR fixes:
Fixes #476
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: