Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #568

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Bump dependencies #568

merged 1 commit into from
Aug 2, 2022

Conversation

praveenrewar
Copy link
Member

What this PR does / why we need it:

Bump json-iterator and reflect2

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@praveenrewar praveenrewar requested a review from a team August 2, 2022 10:57
sethiyash
sethiyash approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@sethiyash sethiyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@100mik
Copy link
Contributor

100mik commented Aug 2, 2022

Related to #566
However, we will need more testing when we bump client-go

@praveenrewar praveenrewar merged commit f2230d0 into develop Aug 2, 2022
@praveenrewar praveenrewar deleted the bump-dependecies branch September 21, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiyash sethiyash sethiyash approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praveenrewar @100mik @sethiyash @vmwclabot