Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move release process to goreleaser #698

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

rohitagg2020
Copy link
Contributor

Move release process to goreleaser.

Signed-off-by: rohitagg2020 rohit.aggarwal2020@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Something for for future, we should move the testing steps to a single step as it's all relevant)

cat checksums.txt | tee -a checksums-formatted.txt
echo \`\`\` | tee -a checksums-formatted.txt
- name: Run GoReleaser
# GoReleaser v4.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should also be removed I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using the commit below, it is good to know this commit belongs to which tag.

@kumaritanushree
Copy link
Contributor

LGTM

@rohitagg2020 rohitagg2020 merged commit f307743 into develop Feb 7, 2023
@praveenrewar praveenrewar deleted the move-release-to-go-releaser branch February 7, 2023 09:34
@kumaritanushree
Copy link
Contributor

/cherry-pick v0.54.x

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error f307743f3d51e8cb38d24d325a4f72420583f132 into temp-cherry-pick-c4b95c-v0.54.x

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Jun 19, 2023
kumaritanushree pushed a commit that referenced this pull request Jun 19, 2023
* Move release process to goreleaser

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Fixing the spaces

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Removing unnecessary command

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Using commit instead of tag

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

---------

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
kumaritanushree pushed a commit that referenced this pull request Jun 19, 2023
* Move release process to goreleaser

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Fixing the spaces

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Removing unnecessary command

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Using commit instead of tag

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

---------

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
kumaritanushree pushed a commit that referenced this pull request Jun 19, 2023
* Move release process to goreleaser

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Fixing the spaces

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Removing unnecessary command

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

* Using commit instead of tag

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>

---------

Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants