-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move release process to goreleaser #698
Conversation
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Something for for future, we should move the testing steps to a single step as it's all relevant)
cat checksums.txt | tee -a checksums-formatted.txt | ||
echo \`\`\` | tee -a checksums-formatted.txt | ||
- name: Run GoReleaser | ||
# GoReleaser v4.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This should also be removed I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using the commit below, it is good to know this commit belongs to which tag.
LGTM |
/cherry-pick v0.54.x |
Cherry-pick failed with |
* Move release process to goreleaser Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Fixing the spaces Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Removing unnecessary command Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Using commit instead of tag Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> --------- Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
* Move release process to goreleaser Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Fixing the spaces Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Removing unnecessary command Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Using commit instead of tag Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> --------- Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
* Move release process to goreleaser Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Fixing the spaces Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Removing unnecessary command Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> * Using commit instead of tag Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> --------- Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Move release process to goreleaser.
Signed-off-by: rohitagg2020 rohit.aggarwal2020@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: