Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use app label as app change label for long app names on 0.53.x line (#685)" #699

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Revert "Use app label as app change label for long app names on 0.53.x line (#685)" #699

merged 1 commit into from
Feb 7, 2023

Conversation

praveenrewar
Copy link
Member

Reverts #691

@praveenrewar
Revert "Use app label as app change label for long app names (#685) (#…
5e31a6f 
…691)"

This reverts commit 1d1eb96.

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
@praveenrewar praveenrewar force-pushed the revert-691-v0.53.x-app-name-limit branch from 4f2200a to 5e31a6f Compare February 7, 2023 07:20
100mik
100mik approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kumaritanushree
Copy link
Contributor

LGTM

@praveenrewar praveenrewar merged commit 975b459 into v0.53.x Feb 7, 2023
@praveenrewar praveenrewar deleted the revert-691-v0.53.x-app-name-limit branch February 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100mik 100mik 100mik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenrewar @kumaritanushree @100mik