Do not create change when app-changes-max-to-keep=0 #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
reviewed
Sep 14, 2023
Existing behaviour for --app-changes-max-to-keep=0: - Create an app change before deployment begins, and garbage collect it at the end New behaviour: Do not create an app change at all, but still keep the last change details in the meta configmap. Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
force-pushed
the
app-changes-max-to-keep
branch
from
f3a88d5
to
6c3e3c4
Compare
rcmadhankumar
pushed a commit
that referenced
this pull request
Oct 5, 2023
Existing behaviour for --app-changes-max-to-keep=0: - Create an app change before deployment begins, and garbage collect it at the end New behaviour: Do not create an app change at all, but still keep the last change details in the meta configmap. Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
rcmadhankumar
pushed a commit
that referenced
this pull request
Oct 5, 2023
Existing behaviour for --app-changes-max-to-keep=0: - Create an app change before deployment begins, and garbage collect it at the end New behaviour: Do not create an app change at all, but still keep the last change details in the meta configmap. Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not create change when app-changes-max-to-keep=0.
Existing behaviour for --app-changes-max-to-keep=0:
New behaviour:
If app changes are already present for an app, and we set the flag value to 0, then it would still need to clean up old app changes.
Which issue(s) this PR fixes:
Fixes #806
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: