kapp app-group deploy should order based on folder names #755 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @rjtch Your changes looks good to me 🚀 (except the debug statement). Could you please sign your commits as well to make the DCO bot happy.
Ideally it would be good if we can add a test as well for this, but I am happy to have that in a separate PR.
rjtch
force-pushed
the
eat/755-should-order-based-on-folder-names
branch
from
b7d9891
to
709014f
Compare
…apps Signed-off-by: rjtch <tchuinkoufongue@gmail.com>
Signed-off-by: rjtch <tchuinkoufongue@gmail.com>
Signed-off-by: rjtch <tchuinkoufongue@gmail.com>
Signed-off-by: rjtch <tchuinkoufongue@gmail.com>
rjtch
force-pushed
the
eat/755-should-order-based-on-folder-names
branch
from
709014f
to
7425ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: