Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some images in examples #876

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update some images in examples #876

merged 1 commit into from
Dec 18, 2023

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Dec 18, 2023

Use artifact registry url instead gcr as images in gcr are not tagged anymore

What this PR does / why we need it:

  • Use artefact registry url for frontend-gb instead of gcr
  • Use registry.k8s.io instead of k8s.gcr.io

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar praveenrewar changed the title Update gb-frontend image in examples guestbook Update some images in examples Dec 18, 2023
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore
Use registry.k8s.io instead of k8s.gcr.io
Bump k8s version in github workflow to 1.21 from 1.16

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Copy link
Contributor

@rohitagg2020 rohitagg2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenrewar praveenrewar merged commit 0f793e1 into develop Dec 18, 2023
5 checks passed
@praveenrewar praveenrewar deleted the examples-guestbook branch December 18, 2023 10:36
rcmadhankumar pushed a commit that referenced this pull request Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore
Use registry.k8s.io instead of k8s.gcr.io
Bump k8s version in github workflow to 1.21 from 1.16

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
rcmadhankumar added a commit that referenced this pull request Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore
Use registry.k8s.io instead of k8s.gcr.io
Bump k8s version in github workflow to 1.21 from 1.16

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
rcmadhankumar added a commit that referenced this pull request Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore
Use registry.k8s.io instead of k8s.gcr.io
Bump k8s version in github workflow to 1.21 from 1.16

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Signed-off-by: rcmadhankumar <rcmadhankumar@gmail.com>
rcmadhankumar pushed a commit that referenced this pull request Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore
Use registry.k8s.io instead of k8s.gcr.io
Bump k8s version in github workflow to 1.21 from 1.16

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants