-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some images in examples #876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenrewar
force-pushed
the
examples-guestbook
branch
from
December 18, 2023 06:08
8640de0
to
5c8447a
Compare
praveenrewar
changed the title
Update gb-frontend image in examples guestbook
Update some images in examples
Dec 18, 2023
praveenrewar
force-pushed
the
examples-guestbook
branch
from
December 18, 2023 08:20
5c8447a
to
146a5b7
Compare
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore Use registry.k8s.io instead of k8s.gcr.io Bump k8s version in github workflow to 1.21 from 1.16 Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
force-pushed
the
examples-guestbook
branch
from
December 18, 2023 10:10
146a5b7
to
d1649f5
Compare
rohitagg2020
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rcmadhankumar
pushed a commit
that referenced
this pull request
Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore Use registry.k8s.io instead of k8s.gcr.io Bump k8s version in github workflow to 1.21 from 1.16 Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
rcmadhankumar
added a commit
that referenced
this pull request
Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore Use registry.k8s.io instead of k8s.gcr.io Bump k8s version in github workflow to 1.21 from 1.16 Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
rcmadhankumar
added a commit
that referenced
this pull request
Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore Use registry.k8s.io instead of k8s.gcr.io Bump k8s version in github workflow to 1.21 from 1.16 Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com> Signed-off-by: rcmadhankumar <rcmadhankumar@gmail.com>
rcmadhankumar
pushed a commit
that referenced
this pull request
Apr 16, 2024
Use artifact registry url for gb-frontend instead of gcr as images in gcr are not tagged anymore Use registry.k8s.io instead of k8s.gcr.io Bump k8s version in github workflow to 1.21 from 1.16 Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use artifact registry url instead gcr as images in gcr are not tagged anymore
What this PR does / why we need it:
registry.k8s.io
instead ofk8s.gcr.io
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: