Default rule to make sure service-account is created before secret associated with that service-account #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiyash
requested review from
praveenrewar,
kumaritanushree,
100mik and
rohitagg2020
sethiyash
force-pushed
the
ordering-sa-secret
branch
from
7663eca
to
bd604a9
Compare
sethiyash
changed the title
sethiyash
changed the title
sethiyash
changed the title
There was a problem hiding this comment.
@sethiyash would you like to go through these tests once and if possible add similar for your changes as well?
…ted after service-account is created Signed-off-by: Yash Sethiya <yashsethiya97@gmail.com>
sethiyash
force-pushed
the
ordering-sa-secret
branch
2 times, most recently
from
8fdd44e
to
212e27b
Compare
Signed-off-by: Yash Sethiya <yashsethiya97@gmail.com>
sethiyash
force-pushed
the
ordering-sa-secret
branch
from
212e27b
to
1283331
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Default rule to make sure secret associated with service-account created after service-account is created
Which issue(s) this PR fixes:
#514
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: