[KAPP-71] Watch pods in specific namespace when needed #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a namespace-scoped RBAC user is used by kubectl, and this user doesn't have privilege to watch pods in all namespaces, we should only watch the namespace specified by '-n' flag or default to the namespace specified in kubeconfig. Manually tested on Mac OS and the error msg is gone: `./kapp deploy -a myapp -f examples/gitops/guestbook/`
cppforlife
reviewed
Apr 6, 2020
cppforlife
reviewed
Apr 6, 2020
*Save fallbackAllowedNamespaces onto IdentifiedResources directly * Use errors.IsForbidden(err) check permission error for watching all pods
|
closed-reopened PR for test-gh workflow to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a namespace-scoped RBAC user is used by kubectl, and this
user doesn't have privilege to watch pods in all namespaces,
we should only watch the namespace specified by '-n' flag or
default to the namespace specified in kubeconfig.
Manually tested on Mac OS and the error msg is gone:
./kapp deploy -a myapp -f examples/gitops/guestbook/Close #71