Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright headers #369

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Update copyright headers #369

merged 1 commit into from
Mar 25, 2024

Conversation

prashantrewar
Copy link
Contributor

Fixes #366

joaopapereira
joaopapereira requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR, we need to do some extra changes.
We need to change the file https://github.com/carvel-dev/vendir/blob/develop/code-header-template.txt to ensure that the linter is happy.
We should not change any of the files under vendor folder, that change will come in when we make the change on imgpkg

@prashantrewar
Update copyright headers
4cf9128 
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar
Copy link
Contributor Author

Thank you @joaopapereira for the suggestion.

I made the changes. Please take a look.

joaopapereira
joaopapereira approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 9fa4c21 into carvel-dev:develop Mar 25, 2024
4 checks passed
@prashantrewar prashantrewar deleted the update-copyright-header branch March 26, 2024 05:24
renovate bot referenced this pull request in mykso/myks Apr 20, 2024
@renovate
fix(deps): update module carvel.dev/vendir to v0.40.1 (#270)
fec8d50 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [carvel.dev/vendir](https://togithub.com/carvel-dev/vendir) |
`v0.40.0` -> `v0.40.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/carvel.dev%2fvendir/v0.40.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/carvel.dev%2fvendir/v0.40.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/carvel.dev%2fvendir/v0.40.0/v0.40.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/carvel.dev%2fvendir/v0.40.0/v0.40.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>carvel-dev/vendir (carvel.dev/vendir)</summary>

###
[`v0.40.1`](https://togithub.com/carvel-dev/vendir/releases/tag/v0.40.1)

[Compare
Source](https://togithub.com/carvel-dev/vendir/compare/v0.40.0...v0.40.1)

<details>

<summary><h2>Installation and signature verification</h2></summary>

##### Installation
##### By downloading binary from the release

For instance, if you are using Linux on an AMD64 architecture:

```shell

### Download the binary
curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.1/vendir-linux-amd64

### Move the binary in to your PATH
mv vendir-linux-amd64 /usr/local/bin/vendir

### Make the binary executable
chmod +x /usr/local/bin/vendir
```

##### Via Homebrew (macOS or Linux)

```shell
$ brew tap carvel-dev/carvel
$ brew install vendir
$ vendir version  
```

##### Verify checksums file signature

Install cosign on your system
https://docs.sigstore.dev/system_config/installation/

The checksums file provided within the artifacts attached to this
release is signed using
[Cosign](https://docs.sigstore.dev/cosign/overview/) with GitHub OIDC.
To validate the signature of this file, run the following commands:

```shell

### Download the checksums file, certificate and signature
curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.1/checksums.txt
curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.1/checksums.txt.pem
curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.1/checksums.txt.sig

### Verify the checksums file
cosign verify-blob checksums.txt \
  --certificate checksums.txt.pem \
  --signature checksums.txt.sig \
  --certificate-identity-regexp=https://github.com/carvel-dev \
  --certificate-oidc-issuer=https://token.actions.githubusercontent.com
```

##### Verify binary integrity

To verify the integrity of the downloaded binary, you can utilize the
checksums file after having validated its signature.

```shell

### Verify the binary using the checksums file
sha256sum -c checksums.txt --ignore-missing
```

</details>

### ✨ What's new
* fix: close tmp file before rename by
@&#8203;meier-christo[https://github.com/carvel-dev/vendir/pull/360](https://togithub.com/carvel-dev/vendir/pull/360)ll/360
* Make version more flexible to allow vendir to be used as a library by
@&#8203;joaopaperei[https://github.com/carvel-dev/vendir/pull/365](https://togithub.com/carvel-dev/vendir/pull/365)ll/365
* Update copyright headers by
@&#8203;prashantrew[https://github.com/carvel-dev/vendir/pull/369](https://togithub.com/carvel-dev/vendir/pull/369)ll/369
* Use latest github.com/carvel-dev/semver by
@&#8203;mamachan[https://github.com/carvel-dev/vendir/pull/373](https://togithub.com/carvel-dev/vendir/pull/373)ll/373
* Bump go version 1.22.2 and imgpkg v0.42.0 by
@&#8203;rcmadhankum[https://github.com/carvel-dev/vendir/pull/378](https://togithub.com/carvel-dev/vendir/pull/378)ll/378

### 🔈 Callouts
* @&#8203;prashantrewar made their first
contributi[https://github.com/carvel-dev/vendir/pull/369](https://togithub.com/carvel-dev/vendir/pull/369)ll/369
* @&#8203;grokspawn made their first
contributi[https://github.com/carvel-dev/vendir/pull/370](https://togithub.com/carvel-dev/vendir/pull/370)ll/370
* @&#8203;mamachanko made their first
contributi[https://github.com/carvel-dev/vendir/pull/373](https://togithub.com/carvel-dev/vendir/pull/373)ll/373

**Full Changelog**:
carvel-dev/vendir@v0.40.0...v0.40.1

### 📂 Files Checksum

3941cf7b7ba1219d574b93ce1bd8b77928ad9ff9cdf8e2debf3ae11ae695792f
./vendir-darwin-amd64
34974c9a6a6e32eb21adac47ce72df6340d36886b5ebe8b5937444a0d7ecc529
./vendir-darwin-arm64
d7c602d8882085be78cd02a575a6c3b437bb2fa1ff1067712f593d8cf05c94fa
./vendir-linux-amd64
43e98922103ef30995a11bd4491b138b635c9b7bf17f98475fb5a06c87392e1d
./vendir-linux-arm64
7d240b999712e617021e057afeabf2803a89ab93ca91f44a58e063fa74d7eee3
./vendir-windows-amd64.exe

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/mykso/myks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update copyright headers
2 participants
@prashantrewar @joaopapereira