feat: Completion of Enforcer API #103
Merged
+378
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmperorYP7
force-pushed
the
api-completion
branch
3 times, most recently
from
ffec279
to
d8d7f1d
Compare
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> feat: Added logger and function definitions Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> fix: Fixed build errors on unix Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> fix: Logger path Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> fix: include error Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> feat: Added dummy definitions Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in> fix: Fixed errors fix: final fix for UNIX systems Signed-off-by: EmperorYP7 <yash.btech.cs19@iiitranchi.ac.in>
EmperorYP7
force-pushed
the
api-completion
branch
from
d8d7f1d
to
47079df
Compare
xcaptain
reviewed
Jun 7, 2021
xcaptain
approved these changes
Jun 7, 2021
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96 partially
Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in
Description
It also changes the convention of using
this->privateMemberto access private members of a class to justm_privateMember.In compliance with const reference for strings and vectors to prevent multiple allocations.