Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV values escaped using \ #356

Closed
pzet123 opened this issue Aug 17, 2023 · 4 comments · Fixed by #357
Closed

CSV values escaped using \ #356

pzet123 opened this issue Aug 17, 2023 · 4 comments · Fixed by #357
Assignees
@hsluoyz
Labels
bug

Comments

@pzet123
Copy link
Contributor

pzet123 commented Aug 17, 2023

Escaping CSV values was discussed in #243 however the resolution in the end was to use \ for escaping commas in CSV files.

This causes an issue when trying to share policies between different versions of Casbin (e.g. Node-Casbin and jCasbin) which use double quotation marks to format values. This is the preferred technique described in RFC4180.

Is there any reason not to switch to the method of escaping CSV values described in RFC4180?
@casbin-bot
Copy link
Member

@tangyang9464 @imp2002

@hsluoyz
Copy link
Member

hsluoyz commented Aug 17, 2023

@pzet123 hi, can you make a PR?

@hsluoyz
Copy link
Member

hsluoyz commented Aug 26, 2023

@pzet123 any update?

@pzet123 pzet123 mentioned this issue Aug 26, 2023
Merged
@pzet123
Copy link
Contributor Author

pzet123 commented Aug 26, 2023

Submitted PR

@hsluoyz hsluoyz added bug and removed question labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Improve CSV file parsing pzet123/jcasbin
3 participants
@hsluoyz @pzet123 @casbin-bot