Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve CSV file parsing #357

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

pzet123
Copy link
Contributor

@pzet123 pzet123 commented Aug 26, 2023

Fix: #356

Fixed some formatting issues and added new test cases while I was at it.

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

Codecov Report

Merging #357 (60dbaf9) into master (8c50f92) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   69.36%   69.37%   +0.01%     
==========================================
  Files          49       49              
  Lines        2236     2237       +1     
  Branches      398      398              
==========================================
+ Hits         1551     1552       +1     
  Misses        574      574              
  Partials      111      111              
Files Changed Coverage Δ
src/main/java/org/casbin/jcasbin/util/Util.java 59.79% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hsluoyz hsluoyz changed the title fix: Improve CSV file reading feat: Improve CSV file parsing Aug 26, 2023
@hsluoyz hsluoyz merged commit 3d22ec5 into casbin:master Aug 26, 2023
1 check passed
@github-actions
Copy link

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV values escaped using \
4 participants