fix: use rtype to get request tokens in CoreEnforcer #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @imp2002 please review |
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 69.58% 69.36% -0.22%
==========================================
Files 49 49
Lines 2229 2236 +7
Branches 399 398 -1
==========================================
Hits 1551 1551
- Misses 567 574 +7
Partials 111 111
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🎉 This PR is included in version 1.37.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, the
CoreEnforcerclass was previously using the number of tokens within different request types to determine which request type that user has passed in. This causes issues when you have multiple request types with the same number of tokens.I've changed this so that the
rtypeis used to determine from which request type the tokens should be retrieved, similarly to how the policy tokens are retrieved.The message being passed into
CasbinMatcherExceptionwas also incorrect as it referencedrvalsbut was really getting length values frompvalsSome minor spelling mistakes fixed too.