Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync rbac_with_pattern model test cases #374

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Jan 25, 2024

  1. fix rbac_with_pattern model error on test case and add test case
  2. sync test case TestBasicModelWithoutSpaces
  3. sync test caseTestRBACModelWithDomainsAtRuntimeMockAdapter

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (899dc83) 69.00% compared to head (ccea966) 68.94%.

Files Patch % Lines
...sbin/jcasbin/persist/file_adapter/AdapterMock.java 60.86% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   69.00%   68.94%   -0.06%     
==========================================
  Files          52       53       +1     
  Lines        2326     2351      +25     
  Branches      411      414       +3     
==========================================
+ Hits         1605     1621      +16     
- Misses        614      623       +9     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz changed the title fix: sync rbac_with_pattern feat: sync rbac_with_pattern model test cases Jan 27, 2024
@hsluoyz hsluoyz merged commit 00bc8e8 into casbin:master Jan 27, 2024
4 of 5 checks passed
Copy link

🎉 This PR is included in version 1.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LMay001 LMay001 deleted the fix_model branch January 27, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants