Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rbac-with-conditions for jcasbin #392

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Mar 26, 2024

feat: support rbac-with-conditions for jcasbin

Fix: #384

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.53968% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 67.80%. Comparing base (c7d1c21) to head (bfce89a).

Files Patch % Lines
...rg/casbin/jcasbin/rbac/ConditionalRoleManager.java 62.92% 17 Missing and 16 partials ⚠️
.../main/java/org/casbin/jcasbin/model/Assertion.java 38.46% 27 Missing and 5 partials ⚠️
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 75.80% 12 Missing and 3 partials ⚠️
...java/org/casbin/jcasbin/util/BuiltInFunctions.java 77.35% 7 Missing and 5 partials ⚠️
.../org/casbin/jcasbin/rbac/LinkConditionFuncKey.java 37.50% 6 Missing and 4 partials ⚠️
src/main/java/org/casbin/jcasbin/rbac/Role.java 66.66% 9 Missing ⚠️
src/main/java/org/casbin/jcasbin/model/Policy.java 56.25% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   68.92%   67.80%   -1.12%     
==========================================
  Files          53       55       +2     
  Lines        2420     2721     +301     
  Branches      427      505      +78     
==========================================
+ Hits         1668     1845     +177     
- Misses        638      725      +87     
- Partials      114      151      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz merged commit 536d194 into casbin:master Mar 27, 2024
3 of 5 checks passed
Copy link

🎉 This PR is included in version 1.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Jcasbin support rbac-with-conditions?
4 participants