fix: fix bug in add policy for priority effectors #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nekotoxin please review |
|
|
aditya-nambiar
force-pushed
the
aditya/fix
branch
from
cfd3bca
to
7940581
Compare
aditya-nambiar
changed the title
aditya-nambiar
changed the title
aditya-nambiar
force-pushed
the
aditya/fix
branch
from
7940581
to
57ee4eb
Compare
|
@BustDot plz review |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
## [1.23.1](v1.23.0...v1.23.1) (2023-08-10) ### Bug Fixes * fix bug in add policy for priority effectors ([#313](#313)) ([8d30537](8d30537))
|
🎉 This PR is included in version 1.23.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #310
Description:
Fixes a bug in assigning an index to a new policy was added when using the priority effector.
The bug is that when we loop from range(i, 0, -1), i stops at 1 ( since range is exclusive for the end parameter ), and hence we cant assign a policy to index 0 in this logic ( in case the newly added policy indeed has the lowest priority )
I swapped it for a simpler logic that bubbles up the inserted policy to the correct index.
Related Issue:
#310
Tests:
Ran - python3 -m unittest discover
OK