Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case_validate: Expose CDO IRI typo-checker as function #121

Merged
merged 2 commits into from
Aug 22, 2023
Merged

case_validate: Expose CDO IRI typo-checker as function #121

merged 2 commits into from
Aug 22, 2023

Conversation

ajnelson-nist
Copy link
Member

This Pull Request isolates one of the changes from PR #118, exposing the CDO IRI typo-checking functionality as its own callable, testable function.

kchason and others added 2 commits August 9, 2023 08:19
@kchason @ajnelson-nist
Expose unrecognized-concept set construction logic as function
cfe4064 
AJN: This is a partial application of @kchason 's work in PR 118, and is
being pulled into its own patch series to focus review.

References:
* #118

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Add doctest for get_invalid_cdo_concepts
1c636e0 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the 0.12.0 milestone Aug 9, 2023
@ajnelson-nist ajnelson-nist marked this pull request as ready for review August 9, 2023 19:54
@ajnelson-nist ajnelson-nist requested a review from a team as a code owner August 9, 2023 19:54
@ajnelson-nist
Copy link
Member Author

I'm fine with this merging once it passes CI.

@ajnelson-nist ajnelson-nist mentioned this pull request Aug 15, 2023
Merged
@kchason kchason merged commit 39f8f11 into develop Aug 22, 2023
2 checks passed
@kchason kchason deleted the add_case_validate_get_invalid_cdo_concepts branch August 22, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchason kchason kchason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @kchason