Reduce redundant case_validate analysis #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * RDFLib/pySHACL#89 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
From discussion in the Ontology Committees meeting yesterday, it seems the way forward for speeding up UCO SHACL validation might include moving the OWL review shapes to their own repository, and further separating "ABox" shapes from "TBox" shapes. |
ajnelson-nist
added a commit
to casework/CASE-Corpora
that referenced
this pull request
Jan 30, 2023
This patch consolidates the review of CASE-Corpora's knowledge base graph against prerelease states of CASE and UCO. The current implementation reviews each dataset against CASE's `develop` and `unstable` states. Before resolution of the slowdown noted in `case-utils` PR 72, this is a significant time cost that can be decreased by instead reviewing the consolidated knowledge base graph at `/catalog/kb-all.ttl`. This will be a more significant time cost if CASE-Corpora starts reviewing against the `-2.0.0` prerelease builds, using the review scheme outlined in UCO Issue 493. This patch also speeds up CI's review of each dataset by only running per-dataset validation against the current CASE release when not operating in a GitHub Action. This supports local (offline) development still running review in a focused dataset directory. (The Bash syntax used for variable definition detection is compatible with Bash's `set -u`. See tldp.org reference.) A follow-on patch will regenerate Make-managed files. References: * casework/CASE-Utilities-Python#72 * ucoProject/UCO#493 * https://tldp.org/LDP/abs/html/parameter-substitution.html Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to casework/CASE-Corpora
that referenced
this pull request
Jan 30, 2023
This patch consolidates the review of CASE-Corpora's knowledge base graph against prerelease states of CASE and UCO. The current implementation reviews each dataset against CASE's `develop` and `unstable` states. Before resolution of the slowdown noted in `case-utils` PR 72, this is a significant time cost that can be decreased by instead reviewing the consolidated knowledge base graph at `/catalog/kb-all.ttl`. This will be a more significant time cost if CASE-Corpora starts reviewing against the `-2.0.0` prerelease builds, using the review scheme outlined in UCO Issue 493. This patch also speeds up CI's review of each dataset by only running per-dataset validation against the current CASE release when not operating in a GitHub Action. This supports local (offline) development still running review in a focused dataset directory. (The Bash syntax used for variable definition detection is compatible with Bash's `set -u`. See tldp.org reference.) A follow-on patch will regenerate Make-managed files. References: * casework/CASE-Utilities-Python#72 * ucoProject/UCO#493 * https://tldp.org/LDP/abs/html/parameter-substitution.html Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This is part of addressing what originally inspired pySHACL Issue 170. This patch modifies the behavior of `case_validate`, that reviews OWL syntax and OWL-SHACL interactions. With this patch, that functionality is now **opt-in** at call time. Further work on separating the OWL review shapes from UCO into a general CDO repository (originally started for CDOTSC-34) is currently believed to not have an impact on the user interface element where the user opts in to the more extensive review. References: * [CDOTSC-34] CDO should provide shapes for external ontologies and other RDF models, including OWL * RDFLib/pySHACL#170 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
A new backwards-incompatible default behavior has been introduced with I am fine with this being merged after CI passes. |
kchason
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged before some further discussion on pySHACL Issue 170.
There may also be need for some
sh:deactivatedstatements to be applied to theuco-owlnamespace's shapes. A CLI interface may be necessary to toggle those. Design for that will come after the first patch.