Cleanup error reporting code, minor nits #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I gave in into my OCD a bit, tried to use `thiserror` but that seems like not a good fit, so instead made error enum a bit more readable and far shorter. Also, a few tiny nits with trailing commas.
|
Nice, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave in into my OCD a bit, tried to use
thiserrorbut that seems like not a good fit, so instead made error enum a bit more readable and far shorter. Also, a few tiny nits with trailing commas. Lastly, consolidated command formater.Note that in a few places I removed
*inif let Some(v) = *v(v is a&Option<T>) -- seems like it is not needed here