Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute cron tasks #3326

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Distribute cron tasks #3326

wants to merge 33 commits into from

Commits on Aug 20, 2024

  1. Acquire a lease per cron task

    @tgregory-block
    tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fe0c327 View commit details
    Browse the repository at this point in the history

  2. Add backwards compatibility and update README

    @din-cashapp @tgregory-block
    din-cashapp authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2a41ba9 View commit details
    Browse the repository at this point in the history

  3. resolve comments

    @din-cashapp @tgregory-block
    din-cashapp authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4b0b4f9 View commit details
    Browse the repository at this point in the history

  4. API dump

    @tgregory-block
    tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7aa7afe View commit details
    Browse the repository at this point in the history

  5. fixes

    @din-cashapp @tgregory-block
    din-cashapp authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7b7a0a6 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary class name sanitization

    @tgregory-block
    tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    cdf5d07 View commit details
    Browse the repository at this point in the history

  7. Lease held elsewhere WIP

    @tgregory-block
    tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4c8d547 View commit details
    Browse the repository at this point in the history

  8. Implement TestFixture for log collectors 

    GitOrigin-RevId: 453df97428102c5f1959afd94c83d52623e8387c
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7c32ffd View commit details
    Browse the repository at this point in the history

  9. Implement TestFixture for metrics 

    GitOrigin-RevId: c51ec0fb5dcc67f9e1b6b2564678fd86d3f3c416
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8f5b240 View commit details
    Browse the repository at this point in the history

  10. Implement TestFixture for JdbcTestingModule 

    GitOrigin-RevId: 611be8a7a60a1decf8ea787aca23dacf01c1224a
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7c600c8 View commit details
    Browse the repository at this point in the history

  11. Support more source formats and Guice explorer 

    GitOrigin-RevId: b6a255f455c40ef5e21059ab5582a939be572b35
    @damar-block @tgregory-block
    damar-block authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    93c6b21 View commit details
    Browse the repository at this point in the history

  12. Updates the hashing algorithm used in the ClusterHashRing 

    implementation of `ClusterResourceMapper` from `murmur3_32` in the
`com.google.common.hash.Hashing` package, to `murmur3_32_fixed`, which
addresses a bug when generating a hashed value from a string containing
non-BMP characters.

GitOrigin-RevId: f1d4efcd61eb40270b838221bf8a0fc1bca38b1d
    @salamagd @tgregory-block
    salamagd authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3cdb3e4 View commit details
    Browse the repository at this point in the history

  13. Implement TestFixture for dynamodb 

    GitOrigin-RevId: 43385fdc20d5036dd27002569f988ad76328c3e0
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f95301e View commit details
    Browse the repository at this point in the history

  14. Expose service graph in admin console using d3 graph template 

    from https://observablehq.com/@d3/mobile-patent-suits?intent=fork

GitOrigin-RevId: 02456e0997b5e0a5c4c5dd2229edc0326bdabfc1
    @katukota @tgregory-block
    katukota authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f49a286 View commit details
    Browse the repository at this point in the history

  15. Fix InProcessDynamoDbTests for Apple Silicon 

    GitOrigin-RevId: 294c578de959770de4a3b1de8d99c5b122b85984
    @tyiu @tgregory-block
    tyiu authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    30a98f9 View commit details
    Browse the repository at this point in the history

  16. Update misk.feature.Attributes to have a with method that 

    returns a misk class rather than inheriting one that returns a wisp
class.

Previously, if someone with a misk.feature.Attribute called `.with`,
they would get back a wisp class which would be incompatible with the
rest of the misk.feature.* classes they were using.

GitOrigin-RevId: 7c5181263816f14e27fdaf36b4287840119d5ce4
    @ean5533 @tgregory-block
    ean5533 authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3003e10 View commit details
    Browse the repository at this point in the history

  17. Defer the shutdown of JettyService until after Guava managed 

    services are shutdown by default

GitOrigin-RevId: bce36d20af9ef0221f5179e4c7382854e3d7e04d
    @kevink-sq @tgregory-block
    kevink-sq authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2bdbd1a View commit details
    Browse the repository at this point in the history

  18. feat: Add new param to Redis modules for specific config 

    Currently, the
[RedisModule](https://github.com/cashapp/misk/blob/8711bf7a6f68ed7b31237d37d811649d958486f2/misk-redis/src/main/kotlin/misk/redis/RedisModule.kt#L74)
in Misk uses a
[RedisConfig](https://github.com/cashapp/misk/blob/bdb3d56f8a418fa630433a6a8e374405c5a21f1e/misk-redis/src/main/kotlin/misk/redis/RedisConfig.kt#L7)
map where the Jedis client is initialized using the first item in the
map. The map is ordered by insertion which is based on the order of how
configurations are loaded. This setup can lead to unintended
consequences, particularly when multiple Redis clusters are provisioned
for a single environment. This adds a new constructor in `RedisModule`
and `RedisClusterModule` to improve config management by allowing
consumers to provide a specific config to use instead of letting the
module choose from a given configuration map.

GitOrigin-RevId: 5175feb11d51f78f77b723dee9943741bf59b8fd
    @rainecp @tgregory-block
    rainecp authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c8bafb6 View commit details
    Browse the repository at this point in the history

  19. The original implementation of TaggedLogger became heavy, stateful and 

    opinionated. We've reconsidered this approach and
simplified it to just a function call `withSmartTags` doing away
with the stateful builders etc.

COPYBARA_INTEGRATE_REVIEW=#3366 from
GitOrigin-RevId: 508c16fd4046947e33c3e282533841978ef2d1a8
    @afkelsall @tgregory-block
    afkelsall authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0b6ac89 View commit details
    Browse the repository at this point in the history

  20. In this approach, we rebuild the url with path and parse it so that 

    query parameters are extracted.
Advantage of this approach is that tests can pass the full url with
queryparameters (e.g /get?param=value). Disadvantage is that this
changes how we were constructing the url and there is a chance for
breaking old behavior.

GitOrigin-RevId: c5a36bd86576979ac1840f36e6ace3a1c130ed25
    @lakpic @tgregory-block
    lakpic authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6b15723 View commit details
    Browse the repository at this point in the history

  21. Skip resetting DB if DataSourceService has not started 

    GitOrigin-RevId: efb52773373ea3687903bc3fb2825abc36c595bd
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    988a576 View commit details
    Browse the repository at this point in the history

  22. Update MiskTestExtension to stop Jetty in the shutdown hook 

    GitOrigin-RevId: 2d221e51cf17596ec6849d0f2dd4d015df83fe87
    @kevink-sq @tgregory-block
    kevink-sq authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2dd10bb View commit details
    Browse the repository at this point in the history

  23. Injector reuse - support test modules with constructor 

    arguments

GitOrigin-RevId: 05141a51cfaa6cb608383b5aa7d163b72347b114
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c10e0fe View commit details
    Browse the repository at this point in the history

  24. We are not using DefaultBindingScopingVisitor's visitOther 

    function, so we can just implement the interface directly

GitOrigin-RevId: e52510622590f1068de635b97cc73fc4e7a03dac
    @damar-block @tgregory-block
    damar-block authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9cd88a9 View commit details
    Browse the repository at this point in the history

  25. Fixes some misk test reuse injector bugs 

    GitOrigin-RevId: 5c531499ac0f3028ff74d4efbbfceb1344ea7b46
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    75ef2b0 View commit details
    Browse the repository at this point in the history

  26. Add Mutable AI badge to Misk readme 

    GitOrigin-RevId: 22e9c9a4c3bb23f3874d7a1a8dac1bb37df5443d
    @damar-block @tgregory-block
    damar-block authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7adc972 View commit details
    Browse the repository at this point in the history

  27. [Misk Test Flakes] misk.jdbc.CockroachDbRealTransacterTest 

    GitOrigin-RevId: 739c0b99ae9c919d193c972af82e31e23385f04e
    @katukota @tgregory-block
    katukota authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9ac94ab View commit details
    Browse the repository at this point in the history

  28. Only run buildMiskWeb on shadowJar 

    GitOrigin-RevId: 509e8755c63c32910d74beab22ecaacd6935d5fa
    @yissachar @tgregory-block
    yissachar authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a722cfb View commit details
    Browse the repository at this point in the history

  29. Misk test injector reuse - dynamodb reset fix and mockito test 

    fixture

GitOrigin-RevId: 8164ac1d5ed2ce86690a377921b05873aedf4a4e
    @mmollaverdi @tgregory-block
    mmollaverdi authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7744ee3 View commit details
    Browse the repository at this point in the history

  30. Build misk-web on assemble, not just shadowJar 

    GitOrigin-RevId: 489b1ed32a14f269a03f2089c9f577679b46be7c
    @yissachar @tgregory-block
    yissachar authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d705db1 View commit details
    Browse the repository at this point in the history

  31. Revert only building misk-web on assemble 

    GitOrigin-RevId: 23e05e36ea6d3f06c66d25b51b2af5f4eea4c65b
    @yissachar @tgregory-block
    yissachar authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2d2ec8b View commit details
    Browse the repository at this point in the history

  32. Fix flaky test 

    GitOrigin-RevId: 034d8309a3b9b7d471f900134a51f077093ef74c
    @katukota @tgregory-block
    katukota authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    99f639a View commit details
    Browse the repository at this point in the history

  33. Add flush_interval to the LaunchDarklyConfig, default to the 

    default flush interval to allow configuring how often events are sent

GitOrigin-RevId: 5e36390bc9fe80da834a7b8baf036591e85536fa
    @meghans-cash @tgregory-block
    meghans-cash authored and tgregory-block committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6d42628 View commit details
    Browse the repository at this point in the history