Support java record #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhxnlai
force-pushed
the
zl-210123-support-java-record
branch
from
3e67cc4 to
96fc15e
Compare
swankjesse
approved these changes
Feb 4, 2021
| fun getApp(value: A) = appProperty.get(value) | ||
| fun getApp(value: A): P { | ||
| if (!appProperty.isAccessible) { | ||
| appProperty.javaField!!.trySetAccessible() |
There was a problem hiding this comment.
would it be better to set these as accessible when you init the appProperty field?
| @@ -95,7 +94,11 @@ internal class ReflectionCodec<A : Any, D : Any> private constructor( | |||
| .map { it.parameter to it.getDb(dbItem) } | |||
| .toMap() | |||
| val appItem = | |||
| appItemConstructor?.callBy(constructorArgs) ?: appItemClassFactory.newInstance() | |||
| if (appItemConstructor != null && constructorArgs.size == appItemConstructor.parameters.size) { | |||
There was a problem hiding this comment.
wanna add an explicit check to see if it’s a record? rather than relying on constructor parameter count equaling field count?
There was a problem hiding this comment.
This is tricky because this gradle module compiles against Java 11 which doesn't have the Record base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/lang/Record.html