We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Especially for options this feature breaks the intent of the user:
@Test void attributes_String_empty_option() { codeResolver.givenCode("template.jte", "@param String value\n<option value=\"${value}\">Click</option>"); templateEngine.render("template.jte", "", output); assertThat(output.toString()).isEqualTo("<option value=\"\">Click</option>"); }
The actual output currently is: <option>Click</option>
<option>Click</option>
This is semantically different to the expected output: <option value="">Click</option>
<option value="">Click</option>
My proposed solution would be to remove String attributes only if the String is null. @kelunik I think you already suggested this already before.
null
The text was updated successfully, but these errors were encountered:
Indeed, that's how I thought I'd work.
Sorry, something went wrong.
#255 empty String in attribute value does not remove the attribute
3e4c084
casid
No branches or pull requests
Especially for options this feature breaks the intent of the user:
The actual output currently is:
<option>Click</option>
This is semantically different to the expected output:
<option value="">Click</option>
My proposed solution would be to remove String attributes only if the String is
null
. @kelunik I think you already suggested this already before.The text was updated successfully, but these errors were encountered: