Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jte-spring-boot-starter-3 doesn't depend on jte #381

Closed
mhalbritter opened this issue Sep 27, 2024 · 2 comments
Closed

jte-spring-boot-starter-3 doesn't depend on jte #381

mhalbritter opened this issue Sep 27, 2024 · 2 comments
Assignees

Comments

@mhalbritter
Copy link

mhalbritter commented Sep 27, 2024

Hello there!

I've noticed that jte-spring-boot-starter-3 doesn't depend on jte - that means if I only add jte-spring-boot-starter-3 to my project, the auto-configuration doesn't enable, because it's conditional on TemplateEngine, which isn't on the classpath.

The idea behind a starter is that the user only need to add this dependency and it pulls in all other needed dependencies, as described here.

You get a one-stop-shop for all the Spring and related technology that you need without having to hunt through sample code and copy paste loads of dependency descriptors

Would it be possible to add jte as a dependency to jte-spring-boot-starter-3?

@casid
Copy link
Owner

casid commented Sep 28, 2024

Hi @mhalbritter,

thanks for the suggestion and the explanation. That makes a lot of sense.

I changed the dependency to non-optional:
bdd2fcc

@casid casid self-assigned this Sep 28, 2024
@mhalbritter
Copy link
Author

Nice. Thank you!

@casid casid closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants