-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Information on Gas Refunds #128
Conversation
Remove note about cost refunds.
Note from 1.5.8 release to extract information from - "An enhancement in Peregrine is where a refund system has been activated in the Casper protocol, meaning if a contract overpays, then 99% of the unspent fund will be refunded. This is achieved by changing the refund ratio in the configuration from 0% to 99%. This means that whatever was the payment amount made, minus whatever was the actual gas amount, which is the unspent amount, 99% of that will now be refunded and shown in the execution effects. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For CI/CD looks like some dependencies need to be updated. PR #121 from @deuszex takes care of the dependencies and needs to be merged.
error: package `bumpalo v3.15.4` cannot be built because it requires rustc 1.73.0 or newer, while the currently active rustc version is 1.68.0-nightly
Either upgrade to rustc 1.73.0 or newer, or use
cargo update -p bumpalo@3.15.4 --precise ver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we just removing the previous text or adding new one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated to include a note on the new system.
This PR removes newly erroneous information about Casper not giving refunds for unspent CSPR.
As of the Peregrine update, this note is no longer relevant