Redelegate without unbonding #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # execution_engine_testing/test_support/src/wasm_test_builder.rs
darthsiroftardis
requested review from
Fraser999,
mpapierski,
goral09 and
EdHastingsCasperAssociation
|
FYI, I had to unassign myself as the reviewer as I won't be able to do a proper review before the end of 1.5.0 development cycle. |
mpapierski
reviewed
Dec 9, 2021
Fraser999
suggested changes
Dec 10, 2021
There was a problem hiding this comment.
There is one critical issue in process_unbond_requests() which must be resolved.
I'd like to see tests for
- redelegate to an invalid validator
- redelegate to the same validator (should be a no-op resulting in no unbonding purse entry)
The PR also needs to include an entry to each of the EE and types changelogs.
execution_engine_testing/tests/src/test/system_contracts/auction/bids.rs
Outdated
Show resolved
Hide resolved
execution_engine_testing/tests/src/test/system_contracts/auction/bids.rs
Outdated
Show resolved
Hide resolved
execution_engine_testing/tests/src/test/system_contracts/auction/bids.rs
Show resolved
Hide resolved
Fraser999
reviewed
Dec 10, 2021
# Conflicts: # execution_engine/src/core/engine_state/error.rs # resources/test/rpc_schema_hashing_V2.json
# Conflicts: # execution_engine/CHANGELOG.md # types/CHANGELOG.md
Fraser999
reviewed
Jan 12, 2022
Fraser999
reviewed
Jan 12, 2022
Fraser999
approved these changes
Jan 13, 2022
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
goral09
reviewed
Jan 14, 2022
| @@ -13,6 +13,12 @@ All notable changes to this project will be documented in this file. The format | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| * Extended `UnbondingPurses` to take a new field `new_validator` which represents the validator to whom tokens will be re-delegated. | |||
There was a problem hiding this comment.
You forgot to mention that we also changed:
- RPC API
- SSE data
- clients (in this PR only Rust client but the change forces the update to all the other SDKs)
@Fraser999 @darthsiroftardis were these tests included? |
darthsiroftardis
added a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Jan 14, 2022
darthsiroftardis
added a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Jan 21, 2022
2440: Redelegate without unbonding r=darthsiroftardis a=darthsiroftardis CHANGELOG: - Added a `new_validator` field to `UnbondingPurses` which allows redelegation without unbonding - Added a new struct `WithdrawPurse` to represent unbonding purses in current/live networks - Added a new `Key::Unbond` under which `UnbondingPurses` are written - Amended the upgrade logic to transform previous purses that are still be paid out into `UnbondingPurses` Closes casper-network#2345 Co-authored-by: Karan Dhareshwar <karan@casperlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
new_validatorfield toUnbondingPurseswhich allows redelegation without unbondingWithdrawPurseto represent unbonding purses in current/live networksKey::Unbondunder whichUnbondingPursesare writtenUnbondingPursesCloses #2345