Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump casper-wasmi, add sign-ext support #4894

Merged
merged 17 commits into from
Oct 3, 2024
Merged

Bump casper-wasmi, add sign-ext support #4894

merged 17 commits into from
Oct 3, 2024

Conversation

igor-casper
Copy link

@igor-casper igor-casper commented Sep 19, 2024 •
edited by mpapierski
Loading

This PR addresses #4855 by bumping casper-wasmi to 0.14.0

As a key takeaway, sign-ext ops were previously unsupported, which is no longer the case with the newest interpreter. The engine was updated to accommodate this change:

  • chainspec was modified to include ''wasm.opcode_costs.sign'' field which dictates the cost of these ops
  • certain execution engine tests no longer make sense, so they've been removed:
    • should_not_accept_sign_ext_i32_e8s_proposal_wasm
    • should_not_accept_sign_ext_i32_e16s_proposal_wasm
    • should_not_accept_sign_ext_i64_e8s_proposal_wasm
    • should_not_accept_sign_ext_i64_e16s_proposal_wasm
    • should_not_accept_sign_ext_i64_e32s_proposal_wasm
  • the appropriate serialization error no longer mentions unsupported sign extension operators

This PR also bumps the supported nightly toolchain to 2024-07-31.

mpapierski
mpapierski approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@mpapierski mpapierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Need a rust-toolchain bump for smart contracts, and fix possible errors in integration tests as a consequence.

execution_engine/Cargo.toml Outdated Show resolved Hide resolved
@mpapierski mpapierski mentioned this pull request Sep 23, 2024
Open
igor-casper and others added 2 commits September 23, 2024 16:43
@igor-casper
bump smart contracts toolchain
d89d00f
@mpapierski
Update rust-toolchain for smart contracts
4125adc 
Uses most recent I could find that does not emit invalid table
reference.
@igor-casper
Copy link
Author

bors r+

@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit 515aac5 into casper-network:feat-2.0 Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpapierski mpapierski mpapierski approved these changes

@darthsiroftardis darthsiroftardis Awaiting requested review from darthsiroftardis

@EdHastingsCasperAssociation EdHastingsCasperAssociation Awaiting requested review from EdHastingsCasperAssociation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-casper @mpapierski