-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash/Key Type Documentation Revamp #1449
Hash/Key Type Documentation Revamp #1449
Conversation
I'm assuming this will break some other page links and will update accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have questions on this PR, because some of these hashes don't match the output I see in testing. Let's get a tech reviewer or connect on Monday with someone to double-check these and see what I might be misunderstanding.
The file I checked against is casper-node/types/src/key.rs
. I also used the output I shared this week from installing the counter contract on a 2.0 NCTL network.
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR fix/introduce?
The
Hash Types
document grew beyond the original formatting as more key types were added. This PR restructures the document and updates it to include new2.0
types.Checklist
(Delete any that aren't relevant)
yarn install && yarn run build
.../../faq/faq-general.md
- instead of introducing absolute file path, or relative/absolute URL.yarn run check:externals
.Reviewers
@ipopescu