CAS-12599 Add handling API rate limiting and general errors

castle · Jul 4, 2024 · 61260e9 · 61260e9
1 parent 9319c87
commit 61260e9
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## Unreleased
+
+- [#164](https://github.com/castle/castle-node/pull/164)
+  * handle rate limiting and general API errors
+- [#159](https://github.com/castle/castle-node/pull/159)
+  * fix failed event status name
+- [#160](https://github.com/castle/castle-node/pull/160) [#161](https://github.com/castle/castle-node/pull/161) [#162](https://github.com/castle/castle-node/pull/162) [#163](https://github.com/castle/castle-node/pull/163)
+  * Bump dependencies
+
 ## 2.2.1
 
 - [#157](https://github.com/castle/castle-node/pull/157)

diff --git a/src/core/services/core-process-response.service.ts b/src/core/services/core-process-response.service.ts
@@ -8,6 +8,7 @@ import {
   InvalidRequestTokenError,
   InternalServerError,
   APIError,
+  RateLimitError,
 } from '../../errors';
 import { LoggerService } from '../../logger/logger.module';
 
@@ -18,6 +19,7 @@ const RESPONSE_ERRORS = {
   '404': NotFoundError,
   '419': UserUnauthorizedError,
   '422': InvalidParametersError,
+  '429': RateLimitError,
 };
 
 const RESPONSE_SUB_ERRORS = {
@@ -65,10 +67,12 @@ export const CoreProcessResponseService = {
 
     // Throw a special exception for subtype errors if defined. Eg. for
     // invalid request token, which is a subtype of InvalidParametersError.
-    // Otherwise, throw exception as defined per status code
+    // Otherwise, throw exception as defined per status code or a general
+    // API error
     const err =
       RESPONSE_SUB_ERRORS[body.type] ||
-      RESPONSE_ERRORS[response.status.toString()];
+      RESPONSE_ERRORS[response.status.toString()] ||
+      APIError;
 
     throw new err(`Castle: Responded with ${response.status} code`);
   },

diff --git a/src/errors.ts b/src/errors.ts
@@ -68,6 +68,14 @@ export class InvalidRequestTokenError extends InvalidParametersError {
   }
 }
 
+// api error rate limited 429
+export class RateLimitError extends APIError {
+  constructor(message: string) {
+    super(message);
+    this.name = 'RateLimitError';
+  }
+}
+
 // all internal server errors
 export class InternalServerError extends APIError {
   constructor(message: string) {