Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-6351/authenticate handle verdict #101

Merged
merged 25 commits into from
Feb 8, 2021

Conversation

marysieek
Copy link
Contributor

No description provided.

@marysieek marysieek self-assigned this Feb 5, 2021
@marysieek marysieek changed the title Cas 6351/authenticate handle verdict CAS-6351/authenticate handle verdict Feb 5, 2021
@marysieek marysieek requested a review from bartes February 6, 2021 19:11
@marysieek marysieek marked this pull request as ready for review February 6, 2021 19:11
Copy link
Contributor

@bartes bartes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

clearTimeout(timeout);
}

if (response.status >= 500) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we try to handle 500 here and in the process service below . Is that correct ?

@marysieek marysieek requested a review from bartes February 8, 2021 11:06
@marysieek marysieek merged commit 390381f into develop Feb 8, 2021
@marysieek marysieek deleted the CAS-6351/authenticate-handle-verdict branch February 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants