Add filter, risk and log endpoint clients #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawlib
changed the title
dawlib
commented
May 26, 2021
dawlib
commented
May 26, 2021
dawlib
commented
May 26, 2021
dawlib
commented
May 26, 2021
| logger: { info: () => {} }, | ||
| }); | ||
|
|
||
| const response = await APIFilterService.call( |
There was a problem hiding this comment.
Response for filter has such attributes:
{'action': 'allow', 'risk': 0.41, 'policy': {'id': ..., 'revision_id': ..., 'name': ...}, 'signals': {'datacenter_ip': {}}
dawlib
commented
May 26, 2021
| }; | ||
|
|
||
| describe('call', () => { | ||
| it('handles track response', async () => { |
There was a problem hiding this comment.
re. response the "log" action/endpoint will probably behave the same way as "track"
dawlib
commented
May 26, 2021
| }; | ||
|
|
||
| describe('call', () => { | ||
| it('handles allow response', async () => { |
There was a problem hiding this comment.
Response for risk has such attributes:
{'action': 'deny', 'risk': 0.89, 'policy': {'id': '9999bb59-0d60-42d8-8e38-7179d445de90', 'revision_id': 'bc666b75-03e3-4e9e-4444-3226130bab4d', 'name': 'invalidemail'}, 'signals': {'unapproved_device_type': {}, 'unapproved_device': {}, 'unapproved_country': {}, 'datacenter_ip': {}}, 'device': {'fingerprint': 'flEzW_S8S8eYYccT-2HrIw', 'connected_users_count': 1}, 'failover': ..., 'failover_reason': ...}
bartes
approved these changes
Jun 2, 2021
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.