fix: Filter API error handling and types #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnytiago
force-pushed
the
fix/filter_api
branch
from
ec92d16 to
314f26e
Compare
bartes
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Hi @johnytiago. Great pull request!
Yes, it looks like the typings are a bit off.
Let's merge those changes and I will update the rest in the follow-up PR 🚀
Thank you for spotting the problem and providing the fix.
Merged
|
I'm closing this one. Those commits have been applied in the separate PR 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the available API Spec, the Filter API doesn't expect a
user.id, thus thehandleFailovermethod for the Filter API shouldn't either.Also I've added some relevant missing attributes from the payload, but I wasn't thorough. There's plenty more missing like
product,sessionandauthentication_method