Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export configuration types #146

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: export configuration types #146

merged 3 commits into from
Jan 24, 2023

Conversation

johnytiago
Copy link
Contributor

@johnytiago johnytiago commented Jan 21, 2023 •
edited
Loading

  • Changed TSConfig to expose declaration file.
  • Exposed Castle's configuration as CastleConfiguration. Feel free to choose another name.
  • Fixed typo in file name s/configuraton/configuration
  • Adds types to Castle constructor arguments

This time I'll ask you to keep the COMMIT_AUTHOR if you wish to push the code to master 👍🏽

@bartes bartes self-requested a review January 23, 2023 19:10
@bartes bartes self-assigned this Jan 23, 2023
bartes
bartes approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@bartes bartes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. All looks great! 🥇

@bartes bartes merged commit 11f7f5d into castle:develop Jan 24, 2023
@johnytiago johnytiago deleted the master branch January 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartes bartes bartes approved these changes

Assignees

@bartes bartes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnytiago @bartes