Fix proxy generation for private protected constructors

[mriehm]

Previously, it would not be possible to generate a proxy of a class with just a private protected constructor. This is because BaseProxyGenerator.IsConstructorVisible() did not check for the case of MethodBase.IsFamilyAndAssembly.

Now, we remove BaseProxyGenerator.IsConstructorVisible() and replace the call to it with a call to ProxyUtil.IsAccessibleMethod(), which has identical behavior as BaseProxyGenerator.IsConstructorVisible() except that it does already correctly handle MethodBase.IsFamilyAndAssembly.

[stakx]

Looks good to me! I have some trouble understanding the way the tests are written, (but that may just be me not yet fully awake).

[stakx]

You appear to have made commits with different Git user names. Do you want to do something about this before we merge the PR? (I'll wait for a while, just in case.)

[mriehm]

Sorry, I'm still pretty unfamiliar with Github and Git in general (use different source control at work), so I'm not exactly sure how I would go about fixing the inconsistency and it doesn't seem like something worth spending too much time investigating unless you disagree.

So, you can just go ahead and commit this as it is now. Thanks.

[jonorossi]

@mriehm FYI the commits are mixed between these 2 email addresses:

• mriehm@epic.com (no link to your account because this email address is not associated with your GitHub account)
• 3916550+mriehm@users.noreply.github.com (this one got used because you edited files on the GitHub web site and you've got "Keep my email addresses private" set in GitHub's email settings)

@stakx we should just squash and merge the 6 commits anyway to keep the history clean in this case. I'll leave it to you to merge and update the changelog.

[stakx]

to merge and update the changelog

Both done.

Thank you for contributing, @mriehm!